On Thu, May 09, 2024 at 09:19:52PM +0000, Dan Jurgens wrote: > > From: Andrew Lunn <andrew@xxxxxxx> > > Sent: Thursday, May 9, 2024 3:47 PM > > To: Dan Jurgens <danielj@xxxxxxxxxx> > > Subject: Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and > > wake > > > > On Thu, May 09, 2024 at 11:32:15AM -0500, Daniel Jurgens wrote: > > > TX queue stop and wake are counted by some drivers. > > > Support reporting these via netdev-genl queue stats. > > > > > > + name: tx-wake > > > + doc: | > > > + Number of times the tx queue was restarted. > > > + type: uint > > > > I'm curious where these names came from. The opposite of stop would be > > start. The opposite of wake would be sleep. Are these meant to be > > opposites of each other? If they are opposites, why would they differ by > > more than 1? And if they can only differ by 1, why do we need both? > > The names come from the API. netif_tx_stop_queue, netif_tx_wake_queue. O.K. So in that context, these names make sense. Maybe extend the doc: to mention these function names? You say there are a few drivers with these counters? Does it make sense to actually push the increment into netif_tx_stop_queue(), netif_tx_wake_queue() so that they become available for all drivers? I've no idea what that implies... Andrew
