RE: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: Thursday, May 9, 2024 3:47 PM
> To: Dan Jurgens <danielj@xxxxxxxxxx>
> Subject: Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and
> wake
> 
> On Thu, May 09, 2024 at 11:32:15AM -0500, Daniel Jurgens wrote:
> > TX queue stop and wake are counted by some drivers.
> > Support reporting these via netdev-genl queue stats.
> >
> > +        name: tx-wake
> > +        doc: |
> > +          Number of times the tx queue was restarted.
> > +        type: uint
> 
> I'm curious where these names came from. The opposite of stop would be
> start. The opposite of wake would be sleep. Are these meant to be
> opposites of each other? If they are opposites, why would they differ by
> more than 1? And if they can only differ by 1, why do we need both?

The names come from the API. netif_tx_stop_queue, netif_tx_wake_queue. It's true that they can only ever differ by 1, but when they do that's interesting.  Though eventually a TX timeout will occur if it's due to something like a lost interrupt.

The most useful thing is knowing if queues are being stopped frequently, so if there's objection to the wake side it can be dropped.

> 
> 	Andrew






[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux