Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters
From: Halil Pasic <pasic@xxxxxxxxxxxxx>
Date: Tue, 20 Feb 2024 15:18:15 +0100
Cc: Jason Wang <jasowang@xxxxxxxxxx>, virtualization@xxxxxxxxxxxxxxx, Richard Weinberger <richard@xxxxxx>, Anton Ivanov <anton.ivanov@xxxxxxxxxxxxxxxxxx>, Johannes Berg <johannes@xxxxxxxxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>, Vadim Pasternak <vadimp@xxxxxxxxxx>, Bjorn Andersson <andersson@xxxxxxxxxx>, Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>, Cornelia Huck <cohuck@xxxxxxxxxx>, Eric Farman <farman@xxxxxxxxxxxxx>, Heiko Carstens <hca@xxxxxxxxxxxxx>, Vasily Gorbik <gor@xxxxxxxxxxxxx>, Alexander Gordeev <agordeev@xxxxxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, Benjamin Berg <benjamin.berg@xxxxxxxxx>, Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>, linux-um@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, linux-remoteproc@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, Halil Pasic <pasic@xxxxxxxxxxxxx>
In-reply-to: <1706756442.5524123-1-xuanzhuo@linux.alibaba.com>
Organization: IBM
References: <20240130114224.86536-1-xuanzhuo@linux.alibaba.com> <20240130114224.86536-8-xuanzhuo@linux.alibaba.com> <CACGkMEvb4N8kthr4qWXrLOh9v422OYhrYU6hQejusw-e5EacPw@mail.gmail.com> <1706756442.5524123-1-xuanzhuo@linux.alibaba.com>

On Thu, 1 Feb 2024 11:00:42 +0800
Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx> wrote:

> > > And squish the parameters from transport to a structure.  
> > 
> > The patch did more than what is described here, it also switch to use
> > a structure for vring_create_virtqueue() etc.
> > 
> > Is it better to split?  
> 
> Sure.

I understand there will be a v2. From virtio-ccw perspective I have
no objections.

Regards,
Halil

Follow-Ups:
- Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters
  - From: Xuan Zhuo

References:
- [PATCH vhost 00/17] virtio: drivers maintain dma info for premapped vq
  - From: Xuan Zhuo
- [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters
  - From: Xuan Zhuo
- Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters
  - From: Jason Wang
- Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters
  - From: Xuan Zhuo

Prev by Date: Re: [PATCH v3 6/8] iommufd: IOPF-capable hw page table attach/detach/replace
Next by Date: RE: [PATCH net-next] virtio_net: Add TX stop and wake counters
Previous by thread: Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters
Next by thread: Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters
Index(es):
- Date
- Thread

[Index of Archives] [KVM Development] [Libvirt Development] [Libvirt Users] [CentOS Virtualization] [Netdev] [Ethernet Bridging] [Linux Wireless] [Kernel Newbies] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Samba]