Re: [PATCH vhost 07/17] virtio: find_vqs: pass struct instead of multi parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 30, 2024 at 7:42 PM Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx> wrote:
>
> Now, we pass multi parameters to find_vqs. These parameters
> may work for transport or work for vring.
>
> And find_vqs has multi implements in many places:
>
> But every time,
>  arch/um/drivers/virtio_uml.c
>  drivers/platform/mellanox/mlxbf-tmfifo.c
>  drivers/remoteproc/remoteproc_virtio.c
>  drivers/s390/virtio/virtio_ccw.c
>  drivers/virtio/virtio_mmio.c
>  drivers/virtio/virtio_pci_legacy.c
>  drivers/virtio/virtio_pci_modern.c
>  drivers/virtio/virtio_vdpa.c
>
> Every time, we try to add a new parameter, that is difficult.
> We must change every find_vqs implement.
>
> One the other side, if we want to pass a parameter to vring,
> we must change the call path from transport to vring.
> Too many functions need to be changed.
>
> So it is time to refactor the find_vqs. We pass a structure
> cfg to find_vqs(), that will be passed to vring by transport.
>
> And squish the parameters from transport to a structure.

The patch did more than what is described here, it also switch to use
a structure for vring_create_virtqueue() etc.

Is it better to split?

>
> Signed-off-by: Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx>
> ---
>  arch/um/drivers/virtio_uml.c             | 29 +++++++-----
>  drivers/platform/mellanox/mlxbf-tmfifo.c | 14 +++---
>  drivers/remoteproc/remoteproc_virtio.c   | 28 ++++++-----
>  drivers/s390/virtio/virtio_ccw.c         | 33 ++++++-------
>  drivers/virtio/virtio_mmio.c             | 30 ++++++------
>  drivers/virtio/virtio_pci_common.c       | 59 +++++++++++-------------
>  drivers/virtio/virtio_pci_common.h       |  9 +---
>  drivers/virtio/virtio_pci_legacy.c       | 16 ++++---
>  drivers/virtio/virtio_pci_modern.c       | 24 +++++-----
>  drivers/virtio/virtio_ring.c             | 59 ++++++++++--------------
>  drivers/virtio/virtio_vdpa.c             | 33 +++++++------
>  include/linux/virtio_config.h            | 51 ++++++++++++++++----
>  include/linux/virtio_ring.h              | 40 ++++++----------
>  13 files changed, 217 insertions(+), 208 deletions(-)
>
> diff --git a/arch/um/drivers/virtio_uml.c b/arch/um/drivers/virtio_uml.c
> index 8adca2000e51..161bac67e454 100644
> --- a/arch/um/drivers/virtio_uml.c
> +++ b/arch/um/drivers/virtio_uml.c
> @@ -937,11 +937,12 @@ static int vu_setup_vq_call_fd(struct virtio_uml_device *vu_dev,
>  }
>
>  static struct virtqueue *vu_setup_vq(struct virtio_device *vdev,
> -                                    unsigned index, vq_callback_t *callback,
> -                                    const char *name, bool ctx)
> +                                    unsigned index,
> +                                    struct virtio_vq_config *cfg)
>  {
>         struct virtio_uml_device *vu_dev = to_virtio_uml_device(vdev);
>         struct platform_device *pdev = vu_dev->pdev;
> +       struct transport_vq_config tp_cfg = {};

Nit: what did "tp" short for?

>         struct virtio_uml_vq_info *info;
>         struct virtqueue *vq;
>         int num = MAX_SUPPORTED_QUEUE_SIZE;
> @@ -953,10 +954,15 @@ static struct virtqueue *vu_setup_vq(struct virtio_device *vdev,
>                 goto error_kzalloc;
>         }
>         snprintf(info->name, sizeof(info->name), "%s.%d-%s", pdev->name,
> -                pdev->id, name);
> +                pdev->id, cfg->names[cfg->cfg_idx]);
>
> -       vq = vring_create_virtqueue(index, num, PAGE_SIZE, vdev, true, true,
> -                                   ctx, vu_notify, callback, info->name);
> +       tp_cfg.num = num;
> +       tp_cfg.vring_align = PAGE_SIZE;
> +       tp_cfg.weak_barriers = true;
> +       tp_cfg.may_reduce_num = true;
> +       tp_cfg.notify = vu_notify;
> +
> +       vq = vring_create_virtqueue(vdev, index, &tp_cfg, cfg);
>         if (!vq) {
>                 rc = -ENOMEM;
>                 goto error_create;
> @@ -1013,12 +1019,11 @@ static struct virtqueue *vu_setup_vq(struct virtio_device *vdev,
>         return ERR_PTR(rc);
>  }
>
> -static int vu_find_vqs(struct virtio_device *vdev, unsigned nvqs,
> -                      struct virtqueue *vqs[], vq_callback_t *callbacks[],
> -                      const char * const names[], const bool *ctx,
> -                      struct irq_affinity *desc)
> +static int vu_find_vqs(struct virtio_device *vdev, struct virtio_vq_config *cfg)
>  {
>         struct virtio_uml_device *vu_dev = to_virtio_uml_device(vdev);
> +       struct virtqueue **vqs = cfg->vqs;
> +       unsigned int nvqs = cfg->nvqs;
>         int i, queue_idx = 0, rc;
>         struct virtqueue *vq;
>
> @@ -1031,13 +1036,13 @@ static int vu_find_vqs(struct virtio_device *vdev, unsigned nvqs,
>                 return rc;
>
>         for (i = 0; i < nvqs; ++i) {
> -               if (!names[i]) {
> +               if (!cfg->names[i]) {
>                         vqs[i] = NULL;
>                         continue;
>                 }
>
> -               vqs[i] = vu_setup_vq(vdev, queue_idx++, callbacks[i], names[i],
> -                                    ctx ? ctx[i] : false);
> +               cfg->cfg_idx = i;
> +               vqs[i] = vu_setup_vq(vdev, queue_idx++, cfg);
>                 if (IS_ERR(vqs[i])) {
>                         rc = PTR_ERR(vqs[i]);
>                         goto error_setup;
> diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c b/drivers/platform/mellanox/mlxbf-tmfifo.c
> index 5c683b4eaf10..1b5593965068 100644
> --- a/drivers/platform/mellanox/mlxbf-tmfifo.c
> +++ b/drivers/platform/mellanox/mlxbf-tmfifo.c
> @@ -989,15 +989,12 @@ static void mlxbf_tmfifo_virtio_del_vqs(struct virtio_device *vdev)
>
>  /* Create and initialize the virtual queues. */
>  static int mlxbf_tmfifo_virtio_find_vqs(struct virtio_device *vdev,
> -                                       unsigned int nvqs,
> -                                       struct virtqueue *vqs[],
> -                                       vq_callback_t *callbacks[],
> -                                       const char * const names[],
> -                                       const bool *ctx,
> -                                       struct irq_affinity *desc)
> +                                       struct virtio_vq_config *cfg)
>  {
>         struct mlxbf_tmfifo_vdev *tm_vdev = mlxbf_vdev_to_tmfifo(vdev);
> +       struct virtqueue **vqs = cfg->vqs;
>         struct mlxbf_tmfifo_vring *vring;
> +       unsigned int nvqs = cfg->nvqs;
>         struct virtqueue *vq;
>         int i, ret, size;
>
> @@ -1005,7 +1002,7 @@ static int mlxbf_tmfifo_virtio_find_vqs(struct virtio_device *vdev,
>                 return -EINVAL;
>
>         for (i = 0; i < nvqs; ++i) {
> -               if (!names[i]) {
> +               if (!cfg->names[i]) {
>                         ret = -EINVAL;
>                         goto error;
>                 }
> @@ -1014,10 +1011,11 @@ static int mlxbf_tmfifo_virtio_find_vqs(struct virtio_device *vdev,
>                 /* zero vring */
>                 size = vring_size(vring->num, vring->align);
>                 memset(vring->va, 0, size);
> +

Unnecessary changes.

>                 vq = vring_new_virtqueue(i, vring->num, vring->align, vdev,
>                                          false, false, vring->va,
>                                          mlxbf_tmfifo_virtio_notify,
> -                                        callbacks[i], names[i]);
> +                                        cfg->callbacks[i], cfg->names[i]);
>                 if (!vq) {
>                         dev_err(&vdev->dev, "vring_new_virtqueue failed\n");
>                         ret = -ENOMEM;
> diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c
> index 83d76915a6ad..57d51c9c7b63 100644
> --- a/drivers/remoteproc/remoteproc_virtio.c
> +++ b/drivers/remoteproc/remoteproc_virtio.c
> @@ -102,8 +102,7 @@ EXPORT_SYMBOL(rproc_vq_interrupt);
>
>  static struct virtqueue *rp_find_vq(struct virtio_device *vdev,
>                                     unsigned int id,
> -                                   void (*callback)(struct virtqueue *vq),
> -                                   const char *name, bool ctx)
> +                                   struct virtio_vq_config *cfg)
>  {
>         struct rproc_vdev *rvdev = vdev_to_rvdev(vdev);
>         struct rproc *rproc = vdev_to_rproc(vdev);
> @@ -119,7 +118,7 @@ static struct virtqueue *rp_find_vq(struct virtio_device *vdev,
>         if (id >= ARRAY_SIZE(rvdev->vring))
>                 return ERR_PTR(-EINVAL);
>
> -       if (!name)
> +       if (!cfg->names[cfg->cfg_idx])
>                 return NULL;
>
>         /* Search allocated memory region by name */
> @@ -143,10 +142,12 @@ static struct virtqueue *rp_find_vq(struct virtio_device *vdev,
>          * Create the new vq, and tell virtio we're not interested in
>          * the 'weak' smp barriers, since we're talking with a real device.
>          */
> -       vq = vring_new_virtqueue(id, num, rvring->align, vdev, false, ctx,
> -                                addr, rproc_virtio_notify, callback, name);
> +       vq = vring_new_virtqueue(id, num, rvring->align, vdev, false,
> +                                cfg->ctx ? cfg->ctx[cfg->cfg_idx] : false,
> +                                addr, rproc_virtio_notify, cfg->callbacks[cfg->cfg_idx],
> +                                cfg->names[cfg->cfg_idx]);


Let's pass the structure to vring_new_virtqueue() as
vring_create_virtqueue() did?

>         if (!vq) {
> -               dev_err(dev, "vring_new_virtqueue %s failed\n", name);
> +               dev_err(dev, "vring_new_virtqueue %s failed\n", cfg->names[cfg->cfg_idx]);
>                 rproc_free_vring(rvring);
>                 return ERR_PTR(-ENOMEM);
>         }
> @@ -180,23 +181,20 @@ static void rproc_virtio_del_vqs(struct virtio_device *vdev)
>         __rproc_virtio_del_vqs(vdev);
>  }
>
> -static int rproc_virtio_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
> -                                struct virtqueue *vqs[],
> -                                vq_callback_t *callbacks[],
> -                                const char * const names[],
> -                                const bool * ctx,
> -                                struct irq_affinity *desc)
> +static int rproc_virtio_find_vqs(struct virtio_device *vdev, struct virtio_vq_config *cfg)
>  {
> +       struct virtqueue **vqs = cfg->vqs;
> +       unsigned int nvqs = cfg->nvqs;
>         int i, ret, queue_idx = 0;
>
>         for (i = 0; i < nvqs; ++i) {
> -               if (!names[i]) {
> +               if (!cfg->names[i]) {
>                         vqs[i] = NULL;
>                         continue;
>                 }
>
> -               vqs[i] = rp_find_vq(vdev, queue_idx++, callbacks[i], names[i],
> -                                   ctx ? ctx[i] : false);
> +               cfg->cfg_idx = i;
> +               vqs[i] = rp_find_vq(vdev, queue_idx++, cfg);
>                 if (IS_ERR(vqs[i])) {
>                         ret = PTR_ERR(vqs[i]);
>                         goto error;
> diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c
> index ac67576301bf..c7734cd54187 100644
> --- a/drivers/s390/virtio/virtio_ccw.c
> +++ b/drivers/s390/virtio/virtio_ccw.c
> @@ -499,11 +499,11 @@ static void virtio_ccw_del_vqs(struct virtio_device *vdev)
>  }
>
>  static struct virtqueue *virtio_ccw_setup_vq(struct virtio_device *vdev,
> -                                            int i, vq_callback_t *callback,
> -                                            const char *name, bool ctx,
> -                                            struct ccw1 *ccw)
> +                                            int i, struct ccw1 *ccw,
> +                                            struct virtio_vq_config *cfg)
>  {
>         struct virtio_ccw_device *vcdev = to_vc_device(vdev);
> +       struct transport_vq_config tp_cfg = {};
>         bool (*notify)(struct virtqueue *vq);
>         int err;
>         struct virtqueue *vq = NULL;
> @@ -537,10 +537,14 @@ static struct virtqueue *virtio_ccw_setup_vq(struct virtio_device *vdev,
>                 goto out_err;
>         }
>         may_reduce = vcdev->revision > 0;
> -       vq = vring_create_virtqueue(i, info->num, KVM_VIRTIO_CCW_RING_ALIGN,
> -                                   vdev, true, may_reduce, ctx,
> -                                   notify, callback, name);
>
> +       tp_cfg.num = info->num;
> +       tp_cfg.vring_align = KVM_VIRTIO_CCW_RING_ALIGN;
> +       tp_cfg.weak_barriers = true;
> +       tp_cfg.may_reduce_num = may_reduce;
> +       tp_cfg.notify = notify;
> +
> +       vq = vring_create_virtqueue(vdev, i, &tp_cfg, cfg);
>         if (!vq) {
>                 /* For now, we fail if we can't get the requested size. */
>                 dev_warn(&vcdev->cdev->dev, "no vq\n");
> @@ -650,15 +654,13 @@ static int virtio_ccw_register_adapter_ind(struct virtio_ccw_device *vcdev,
>         return ret;
>  }
>
> -static int virtio_ccw_find_vqs(struct virtio_device *vdev, unsigned nvqs,
> -                              struct virtqueue *vqs[],
> -                              vq_callback_t *callbacks[],
> -                              const char * const names[],
> -                              const bool *ctx,
> -                              struct irq_affinity *desc)
> +static int virtio_ccw_find_vqs(struct virtio_device *vdev,
> +                              struct virtio_vq_config *cfg)
>  {
>         struct virtio_ccw_device *vcdev = to_vc_device(vdev);
> +       struct virtqueue **vqs = cfg->vqs;
>         unsigned long *indicatorp = NULL;
> +       unsigned int nvqs = cfg->nvqs;
>         int ret, i, queue_idx = 0;
>         struct ccw1 *ccw;
>
> @@ -667,14 +669,13 @@ static int virtio_ccw_find_vqs(struct virtio_device *vdev, unsigned nvqs,
>                 return -ENOMEM;
>
>         for (i = 0; i < nvqs; ++i) {
> -               if (!names[i]) {
> +               if (!cfg->names[i]) {
>                         vqs[i] = NULL;
>                         continue;
>                 }
>
> -               vqs[i] = virtio_ccw_setup_vq(vdev, queue_idx++, callbacks[i],
> -                                            names[i], ctx ? ctx[i] : false,
> -                                            ccw);
> +               cfg->cfg_idx = i;
> +               vqs[i] = virtio_ccw_setup_vq(vdev, queue_idx++, ccw, cfg);
>                 if (IS_ERR(vqs[i])) {
>                         ret = PTR_ERR(vqs[i]);
>                         vqs[i] = NULL;
> diff --git a/drivers/virtio/virtio_mmio.c b/drivers/virtio/virtio_mmio.c
> index 59892a31cf76..ceb7c312a616 100644
> --- a/drivers/virtio/virtio_mmio.c
> +++ b/drivers/virtio/virtio_mmio.c
> @@ -370,10 +370,10 @@ static void vm_synchronize_cbs(struct virtio_device *vdev)
>  }
>
>  static struct virtqueue *vm_setup_vq(struct virtio_device *vdev, unsigned int index,
> -                                 void (*callback)(struct virtqueue *vq),
> -                                 const char *name, bool ctx)
> +                                    struct virtio_vq_config *cfg)
>  {
>         struct virtio_mmio_device *vm_dev = to_virtio_mmio_device(vdev);
> +       struct transport_vq_config tp_cfg = {};
>         bool (*notify)(struct virtqueue *vq);
>         struct virtio_mmio_vq_info *info;
>         struct virtqueue *vq;
> @@ -386,7 +386,7 @@ static struct virtqueue *vm_setup_vq(struct virtio_device *vdev, unsigned int in
>         else
>                 notify = vm_notify;
>
> -       if (!name)
> +       if (!cfg->names[index])
>                 return NULL;
>
>         /* Select the queue we're interested in */
> @@ -412,9 +412,14 @@ static struct virtqueue *vm_setup_vq(struct virtio_device *vdev, unsigned int in
>                 goto error_new_virtqueue;
>         }
>
> +       tp_cfg.num = num;
> +       tp_cfg.vring_align = VIRTIO_MMIO_VRING_ALIGN;
> +       tp_cfg.weak_barriers = true;
> +       tp_cfg.may_reduce_num = true;
> +       tp_cfg.notify = notify;
> +
>         /* Create the vring */
> -       vq = vring_create_virtqueue(index, num, VIRTIO_MMIO_VRING_ALIGN, vdev,
> -                                true, true, ctx, notify, callback, name);
> +       vq = vring_create_virtqueue(vdev, index, &tp_cfg, cfg);
>         if (!vq) {
>                 err = -ENOMEM;
>                 goto error_new_virtqueue;
> @@ -487,15 +492,12 @@ static struct virtqueue *vm_setup_vq(struct virtio_device *vdev, unsigned int in
>         return ERR_PTR(err);
>  }
>
> -static int vm_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
> -                      struct virtqueue *vqs[],
> -                      vq_callback_t *callbacks[],
> -                      const char * const names[],
> -                      const bool *ctx,
> -                      struct irq_affinity *desc)
> +static int vm_find_vqs(struct virtio_device *vdev, struct virtio_vq_config *cfg)
>  {
>         struct virtio_mmio_device *vm_dev = to_virtio_mmio_device(vdev);
>         int irq = platform_get_irq(vm_dev->pdev, 0);
> +       struct virtqueue **vqs = cfg->vqs;
> +       unsigned int nvqs = cfg->nvqs;
>         int i, err, queue_idx = 0;
>
>         if (irq < 0)
> @@ -510,13 +512,13 @@ static int vm_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
>                 enable_irq_wake(irq);
>
>         for (i = 0; i < nvqs; ++i) {
> -               if (!names[i]) {
> +               if (!cfg->names[i]) {
>                         vqs[i] = NULL;
>                         continue;
>                 }
>
> -               vqs[i] = vm_setup_vq(vdev, queue_idx++, callbacks[i], names[i],
> -                                    ctx ? ctx[i] : false);
> +               cfg->cfg_idx = i;
> +               vqs[i] = vm_setup_vq(vdev, queue_idx++, cfg);
>                 if (IS_ERR(vqs[i])) {
>                         vm_del_vqs(vdev);
>                         return PTR_ERR(vqs[i]);
> diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c
> index 1d21d1a1b3f5..0ebee2b53eed 100644
> --- a/drivers/virtio/virtio_pci_common.c
> +++ b/drivers/virtio/virtio_pci_common.c
> @@ -172,9 +172,7 @@ static int vp_request_msix_vectors(struct virtio_device *vdev, int nvectors,
>  }
>
>  static struct virtqueue *vp_setup_vq(struct virtio_device *vdev, unsigned int index,
> -                                    void (*callback)(struct virtqueue *vq),
> -                                    const char *name,
> -                                    bool ctx,
> +                                    struct virtio_vq_config *cfg,
>                                      u16 msix_vec)
>  {
>         struct virtio_pci_device *vp_dev = to_vp_device(vdev);
> @@ -186,13 +184,13 @@ static struct virtqueue *vp_setup_vq(struct virtio_device *vdev, unsigned int in
>         if (!info)
>                 return ERR_PTR(-ENOMEM);
>
> -       vq = vp_dev->setup_vq(vp_dev, info, index, callback, name, ctx,
> +       vq = vp_dev->setup_vq(vp_dev, info, index, cfg,
>                               msix_vec);
>         if (IS_ERR(vq))
>                 goto out_info;
>
>         info->vq = vq;
> -       if (callback) {
> +       if (cfg->callbacks[cfg->cfg_idx]) {
>                 spin_lock_irqsave(&vp_dev->lock, flags);
>                 list_add(&info->node, &vp_dev->virtqueues);
>                 spin_unlock_irqrestore(&vp_dev->lock, flags);
> @@ -281,15 +279,15 @@ void vp_del_vqs(struct virtio_device *vdev)
>         vp_dev->vqs = NULL;
>  }
>
> -static int vp_find_vqs_msix(struct virtio_device *vdev, unsigned int nvqs,
> -               struct virtqueue *vqs[], vq_callback_t *callbacks[],
> -               const char * const names[], bool per_vq_vectors,
> -               const bool *ctx,
> -               struct irq_affinity *desc)
> +static int vp_find_vqs_msix(struct virtio_device *vdev,
> +                           struct virtio_vq_config *cfg,
> +                           bool per_vq_vectors)
>  {
>         struct virtio_pci_device *vp_dev = to_vp_device(vdev);
>         u16 msix_vec;
>         int i, err, nvectors, allocated_vectors, queue_idx = 0;
> +       struct virtqueue **vqs = cfg->vqs;
> +       unsigned int nvqs = cfg->nvqs;
>
>         vp_dev->vqs = kcalloc(nvqs, sizeof(*vp_dev->vqs), GFP_KERNEL);
>         if (!vp_dev->vqs)
> @@ -299,7 +297,7 @@ static int vp_find_vqs_msix(struct virtio_device *vdev, unsigned int nvqs,
>                 /* Best option: one for change interrupt, one per vq. */
>                 nvectors = 1;
>                 for (i = 0; i < nvqs; ++i)
> -                       if (names[i] && callbacks[i])
> +                       if (cfg->names[i] && cfg->callbacks[i])
>                                 ++nvectors;
>         } else {
>                 /* Second best: one for change, shared for all vqs. */
> @@ -307,27 +305,27 @@ static int vp_find_vqs_msix(struct virtio_device *vdev, unsigned int nvqs,
>         }
>
>         err = vp_request_msix_vectors(vdev, nvectors, per_vq_vectors,
> -                                     per_vq_vectors ? desc : NULL);
> +                                     per_vq_vectors ? cfg->desc : NULL);
>         if (err)
>                 goto error_find;
>
>         vp_dev->per_vq_vectors = per_vq_vectors;
>         allocated_vectors = vp_dev->msix_used_vectors;
>         for (i = 0; i < nvqs; ++i) {
> -               if (!names[i]) {
> +               if (!cfg->names[i]) {
>                         vqs[i] = NULL;
>                         continue;
>                 }
>
> -               if (!callbacks[i])
> +               if (!cfg->callbacks[i])
>                         msix_vec = VIRTIO_MSI_NO_VECTOR;
>                 else if (vp_dev->per_vq_vectors)
>                         msix_vec = allocated_vectors++;
>                 else
>                         msix_vec = VP_MSIX_VQ_VECTOR;
> -               vqs[i] = vp_setup_vq(vdev, queue_idx++, callbacks[i], names[i],
> -                                    ctx ? ctx[i] : false,
> -                                    msix_vec);
> +
> +               cfg->cfg_idx = i;
> +               vqs[i] = vp_setup_vq(vdev, queue_idx++, cfg, msix_vec);
>                 if (IS_ERR(vqs[i])) {
>                         err = PTR_ERR(vqs[i]);
>                         goto error_find;
> @@ -340,7 +338,7 @@ static int vp_find_vqs_msix(struct virtio_device *vdev, unsigned int nvqs,
>                 snprintf(vp_dev->msix_names[msix_vec],
>                          sizeof *vp_dev->msix_names,
>                          "%s-%s",
> -                        dev_name(&vp_dev->vdev.dev), names[i]);
> +                        dev_name(&vp_dev->vdev.dev), cfg->names[i]);
>                 err = request_irq(pci_irq_vector(vp_dev->pci_dev, msix_vec),
>                                   vring_interrupt, 0,
>                                   vp_dev->msix_names[msix_vec],
> @@ -355,11 +353,11 @@ static int vp_find_vqs_msix(struct virtio_device *vdev, unsigned int nvqs,
>         return err;
>  }
>
> -static int vp_find_vqs_intx(struct virtio_device *vdev, unsigned int nvqs,
> -               struct virtqueue *vqs[], vq_callback_t *callbacks[],
> -               const char * const names[], const bool *ctx)
> +static int vp_find_vqs_intx(struct virtio_device *vdev, struct virtio_vq_config *cfg)
>  {
>         struct virtio_pci_device *vp_dev = to_vp_device(vdev);
> +       struct virtqueue **vqs = cfg->vqs;
> +       unsigned int nvqs = cfg->nvqs;
>         int i, err, queue_idx = 0;
>
>         vp_dev->vqs = kcalloc(nvqs, sizeof(*vp_dev->vqs), GFP_KERNEL);
> @@ -374,13 +372,13 @@ static int vp_find_vqs_intx(struct virtio_device *vdev, unsigned int nvqs,
>         vp_dev->intx_enabled = 1;
>         vp_dev->per_vq_vectors = false;
>         for (i = 0; i < nvqs; ++i) {
> -               if (!names[i]) {
> +               if (!cfg->names[i]) {
>                         vqs[i] = NULL;
>                         continue;
>                 }
> -               vqs[i] = vp_setup_vq(vdev, queue_idx++, callbacks[i], names[i],
> -                                    ctx ? ctx[i] : false,
> -                                    VIRTIO_MSI_NO_VECTOR);
> +
> +               cfg->cfg_idx = i;
> +               vqs[i] = vp_setup_vq(vdev, queue_idx++, cfg, VIRTIO_MSI_NO_VECTOR);
>                 if (IS_ERR(vqs[i])) {
>                         err = PTR_ERR(vqs[i]);
>                         goto out_del_vqs;
> @@ -394,26 +392,23 @@ static int vp_find_vqs_intx(struct virtio_device *vdev, unsigned int nvqs,
>  }
>
>  /* the config->find_vqs() implementation */
> -int vp_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
> -               struct virtqueue *vqs[], vq_callback_t *callbacks[],
> -               const char * const names[], const bool *ctx,
> -               struct irq_affinity *desc)
> +int vp_find_vqs(struct virtio_device *vdev, struct virtio_vq_config *cfg)
>  {
>         int err;
>
>         /* Try MSI-X with one vector per queue. */
> -       err = vp_find_vqs_msix(vdev, nvqs, vqs, callbacks, names, true, ctx, desc);
> +       err = vp_find_vqs_msix(vdev, cfg, true);
>         if (!err)
>                 return 0;
>         /* Fallback: MSI-X with one vector for config, one shared for queues. */
> -       err = vp_find_vqs_msix(vdev, nvqs, vqs, callbacks, names, false, ctx, desc);
> +       err = vp_find_vqs_msix(vdev, cfg, false);
>         if (!err)
>                 return 0;
>         /* Is there an interrupt? If not give up. */
>         if (!(to_vp_device(vdev)->pci_dev->irq))
>                 return err;
>         /* Finally fall back to regular interrupts. */
> -       return vp_find_vqs_intx(vdev, nvqs, vqs, callbacks, names, ctx);
> +       return vp_find_vqs_intx(vdev, cfg);
>  }
>
>  const char *vp_bus_name(struct virtio_device *vdev)
> diff --git a/drivers/virtio/virtio_pci_common.h b/drivers/virtio/virtio_pci_common.h
> index 4b773bd7c58c..12b171364e54 100644
> --- a/drivers/virtio/virtio_pci_common.h
> +++ b/drivers/virtio/virtio_pci_common.h
> @@ -79,9 +79,7 @@ struct virtio_pci_device {
>         struct virtqueue *(*setup_vq)(struct virtio_pci_device *vp_dev,
>                                       struct virtio_pci_vq_info *info,
>                                       unsigned int idx,
> -                                     void (*callback)(struct virtqueue *vq),
> -                                     const char *name,
> -                                     bool ctx,
> +                                     struct virtio_vq_config *vq_cfg,
>                                       u16 msix_vec);
>         void (*del_vq)(struct virtio_pci_vq_info *info);
>
> @@ -109,10 +107,7 @@ bool vp_notify(struct virtqueue *vq);
>  /* the config->del_vqs() implementation */
>  void vp_del_vqs(struct virtio_device *vdev);
>  /* the config->find_vqs() implementation */
> -int vp_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
> -               struct virtqueue *vqs[], vq_callback_t *callbacks[],
> -               const char * const names[], const bool *ctx,
> -               struct irq_affinity *desc);
> +int vp_find_vqs(struct virtio_device *vdev, struct virtio_vq_config *cfg);
>  const char *vp_bus_name(struct virtio_device *vdev);
>
>  /* Setup the affinity for a virtqueue:
> diff --git a/drivers/virtio/virtio_pci_legacy.c b/drivers/virtio/virtio_pci_legacy.c
> index d9cbb02b35a1..508a31a81499 100644
> --- a/drivers/virtio/virtio_pci_legacy.c
> +++ b/drivers/virtio/virtio_pci_legacy.c
> @@ -110,11 +110,10 @@ static u16 vp_config_vector(struct virtio_pci_device *vp_dev, u16 vector)
>  static struct virtqueue *setup_vq(struct virtio_pci_device *vp_dev,
>                                   struct virtio_pci_vq_info *info,
>                                   unsigned int index,
> -                                 void (*callback)(struct virtqueue *vq),
> -                                 const char *name,
> -                                 bool ctx,
> +                                 struct virtio_vq_config *cfg,
>                                   u16 msix_vec)
>  {
> +       struct transport_vq_config tp_cfg = {};
>         struct virtqueue *vq;
>         u16 num;
>         int err;
> @@ -127,11 +126,14 @@ static struct virtqueue *setup_vq(struct virtio_pci_device *vp_dev,
>
>         info->msix_vector = msix_vec;
>
> +       tp_cfg.num = num;
> +       tp_cfg.vring_align = VIRTIO_PCI_VRING_ALIGN;
> +       tp_cfg.weak_barriers = true;
> +       tp_cfg.may_reduce_num = false;
> +       tp_cfg.notify = vp_notify;
> +
>         /* create the vring */
> -       vq = vring_create_virtqueue(index, num,
> -                                   VIRTIO_PCI_VRING_ALIGN, &vp_dev->vdev,
> -                                   true, false, ctx,
> -                                   vp_notify, callback, name);
> +       vq = vring_create_virtqueue(&vp_dev->vdev, index, &tp_cfg, cfg);
>         if (!vq)
>                 return ERR_PTR(-ENOMEM);
>
> diff --git a/drivers/virtio/virtio_pci_modern.c b/drivers/virtio/virtio_pci_modern.c
> index ee6a386d250b..9caca1eeb726 100644
> --- a/drivers/virtio/virtio_pci_modern.c
> +++ b/drivers/virtio/virtio_pci_modern.c
> @@ -336,13 +336,12 @@ static bool vp_notify_with_data(struct virtqueue *vq)
>  static struct virtqueue *setup_vq(struct virtio_pci_device *vp_dev,
>                                   struct virtio_pci_vq_info *info,
>                                   unsigned int index,
> -                                 void (*callback)(struct virtqueue *vq),
> -                                 const char *name,
> -                                 bool ctx,
> +                                 struct virtio_vq_config *cfg,
>                                   u16 msix_vec)
>  {
>
>         struct virtio_pci_modern_device *mdev = &vp_dev->mdev;
> +       struct transport_vq_config tp_cfg = {};
>         bool (*notify)(struct virtqueue *vq);
>         struct virtqueue *vq;
>         u16 num;
> @@ -363,11 +362,14 @@ static struct virtqueue *setup_vq(struct virtio_pci_device *vp_dev,
>
>         info->msix_vector = msix_vec;
>
> +       tp_cfg.num = num;
> +       tp_cfg.vring_align = SMP_CACHE_BYTES;
> +       tp_cfg.weak_barriers = true;
> +       tp_cfg.may_reduce_num = true;
> +       tp_cfg.notify = notify;
> +
>         /* create the vring */
> -       vq = vring_create_virtqueue(index, num,
> -                                   SMP_CACHE_BYTES, &vp_dev->vdev,
> -                                   true, true, ctx,
> -                                   notify, callback, name);
> +       vq = vring_create_virtqueue(&vp_dev->vdev, index, &tp_cfg, cfg);
>         if (!vq)
>                 return ERR_PTR(-ENOMEM);
>
> @@ -390,15 +392,11 @@ static struct virtqueue *setup_vq(struct virtio_pci_device *vp_dev,
>         return ERR_PTR(err);
>  }
>
> -static int vp_modern_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
> -                             struct virtqueue *vqs[],
> -                             vq_callback_t *callbacks[],
> -                             const char * const names[], const bool *ctx,
> -                             struct irq_affinity *desc)
> +static int vp_modern_find_vqs(struct virtio_device *vdev, struct virtio_vq_config *cfg)
>  {
>         struct virtio_pci_device *vp_dev = to_vp_device(vdev);
>         struct virtqueue *vq;
> -       int rc = vp_find_vqs(vdev, nvqs, vqs, callbacks, names, ctx, desc);
> +       int rc = vp_find_vqs(vdev, cfg);
>
>         if (rc)
>                 return rc;
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 5bea25167259..5652ff91c6f9 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -2726,43 +2726,34 @@ static struct virtqueue *__vring_new_virtqueue(unsigned int index,
>         return &vq->vq;
>  }
>
> -struct virtqueue *vring_create_virtqueue(
> -       unsigned int index,
> -       unsigned int num,
> -       unsigned int vring_align,
> -       struct virtio_device *vdev,
> -       bool weak_barriers,
> -       bool may_reduce_num,
> -       bool context,
> -       bool (*notify)(struct virtqueue *),
> -       void (*callback)(struct virtqueue *),
> -       const char *name)
> +struct virtqueue *vring_create_virtqueue(struct virtio_device *vdev,
> +                                        unsigned int index,
> +                                        struct transport_vq_config *tp_cfg,
> +                                        struct virtio_vq_config *cfg)
>  {
> +       struct device *dma_dev;
> +       unsigned int num;
> +       unsigned int vring_align;
> +       bool weak_barriers;
> +       bool may_reduce_num;
> +       bool context;
> +       bool (*notify)(struct virtqueue *_);
> +       void (*callback)(struct virtqueue *_);
> +       const char *name;
>
> -       if (virtio_has_feature(vdev, VIRTIO_F_RING_PACKED))
> -               return vring_create_virtqueue_packed(index, num, vring_align,
> -                               vdev, weak_barriers, may_reduce_num,
> -                               context, notify, callback, name, vdev->dev.parent);
> +       dma_dev = tp_cfg->dma_dev;
> +       if (!dma_dev)
> +               dma_dev  = vdev->dev.parent;

Nit: This seems suboptimal than using "?:" ?

>
> -       return vring_create_virtqueue_split(index, num, vring_align,
> -                       vdev, weak_barriers, may_reduce_num,
> -                       context, notify, callback, name, vdev->dev.parent);
> -}
> -EXPORT_SYMBOL_GPL(vring_create_virtqueue);
> +       num            = tp_cfg->num;
> +       vring_align    = tp_cfg->vring_align;
> +       weak_barriers  = tp_cfg->weak_barriers;
> +       may_reduce_num = tp_cfg->may_reduce_num;
> +       notify         = tp_cfg->notify;
>
> -struct virtqueue *vring_create_virtqueue_dma(
> -       unsigned int index,
> -       unsigned int num,
> -       unsigned int vring_align,
> -       struct virtio_device *vdev,
> -       bool weak_barriers,
> -       bool may_reduce_num,
> -       bool context,
> -       bool (*notify)(struct virtqueue *),
> -       void (*callback)(struct virtqueue *),
> -       const char *name,
> -       struct device *dma_dev)
> -{
> +       name     = cfg->names[cfg->cfg_idx];
> +       callback = cfg->callbacks[cfg->cfg_idx];
> +       context  = cfg->ctx ? cfg->ctx[cfg->cfg_idx] : false;
>
>         if (virtio_has_feature(vdev, VIRTIO_F_RING_PACKED))
>                 return vring_create_virtqueue_packed(index, num, vring_align,
> @@ -2773,7 +2764,7 @@ struct virtqueue *vring_create_virtqueue_dma(
>                         vdev, weak_barriers, may_reduce_num,
>                         context, notify, callback, name, dma_dev);
>  }
> -EXPORT_SYMBOL_GPL(vring_create_virtqueue_dma);
> +EXPORT_SYMBOL_GPL(vring_create_virtqueue);
>
>  /**
>   * virtqueue_resize - resize the vring of vq
> diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
> index 8d63e5923d24..dd58d23f711e 100644
> --- a/drivers/virtio/virtio_vdpa.c
> +++ b/drivers/virtio/virtio_vdpa.c
> @@ -147,7 +147,7 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index,
>  {
>         struct virtio_vdpa_device *vd_dev = to_virtio_vdpa_device(vdev);
>         struct vdpa_device *vdpa = vd_get_vdpa(vdev);
> -       struct device *dma_dev;
> +       struct transport_vq_config tp_cfg = {};
>         const struct vdpa_config_ops *ops = vdpa->config;
>         struct virtio_vdpa_vq_info *info;
>         bool (*notify)(struct virtqueue *vq) = virtio_vdpa_notify;
> @@ -199,12 +199,17 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index,
>         align = ops->get_vq_align(vdpa);
>
>         if (ops->get_vq_dma_dev)
> -               dma_dev = ops->get_vq_dma_dev(vdpa, index);
> +               tp_cfg.dma_dev = ops->get_vq_dma_dev(vdpa, index);
>         else
> -               dma_dev = vdpa_get_dma_dev(vdpa);
> -       vq = vring_create_virtqueue_dma(index, max_num, align, vdev,
> -                                       true, may_reduce_num, ctx,
> -                                       notify, callback, name, dma_dev);
> +               tp_cfg.dma_dev = vdpa_get_dma_dev(vdpa);
> +
> +       tp_cfg.num = max_num;
> +       tp_cfg.vring_align = align;
> +       tp_cfg.weak_barriers = true;
> +       tp_cfg.may_reduce_num = may_reduce_num;
> +       tp_cfg.notify = notify;
> +
> +       vq = vring_create_virtqueue(vdev, index, &tp_cfg, cfg);
>         if (!vq) {
>                 err = -ENOMEM;
>                 goto error_new_virtqueue;
> @@ -353,11 +358,8 @@ create_affinity_masks(unsigned int nvecs, struct irq_affinity *affd)
>         return masks;
>  }
>
> -static int virtio_vdpa_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
> -                               struct virtqueue *vqs[],
> -                               vq_callback_t *callbacks[],
> -                               const char * const names[],
> -                               const bool *ctx,
> +static int virtio_vdpa_find_vqs(struct virtio_device *vdev,
> +                               struct virtio_vq_config *cfg,
>                                 struct irq_affinity *desc)
>  {
>         struct virtio_vdpa_device *vd_dev = to_virtio_vdpa_device(vdev);
> @@ -367,6 +369,8 @@ static int virtio_vdpa_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
>         struct cpumask *masks;
>         struct vdpa_callback cb;
>         bool has_affinity = desc && ops->set_vq_affinity;
> +       struct virtqueue **vqs = cfg->vqs;
> +       unsigned int nvqs = cfg->nvqs;
>         int i, err, queue_idx = 0;
>
>         if (has_affinity) {
> @@ -376,14 +380,13 @@ static int virtio_vdpa_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
>         }
>
>         for (i = 0; i < nvqs; ++i) {
> -               if (!names[i]) {
> +               if (!cfg->names[i]) {
>                         vqs[i] = NULL;
>                         continue;
>                 }
>
> -               vqs[i] = virtio_vdpa_setup_vq(vdev, queue_idx++,
> -                                             callbacks[i], names[i], ctx ?
> -                                             ctx[i] : false);
> +               cfg->cfg_idx = i;
> +               vqs[i] = virtio_vdpa_setup_vq(vdev, queue_idx++, cfg);
>                 if (IS_ERR(vqs[i])) {
>                         err = PTR_ERR(vqs[i]);
>                         goto err_setup_vq;
> diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
> index 2b3438de2c4d..e2c72e125dae 100644
> --- a/include/linux/virtio_config.h
> +++ b/include/linux/virtio_config.h
> @@ -94,6 +94,20 @@ typedef void vq_callback_t(struct virtqueue *);
>   *     If disable_vq_and_reset is set, then enable_vq_after_reset must also be
>   *     set.
>   */
> +
> +struct virtio_vq_config {
> +       unsigned int nvqs;
> +
> +       /* the vq index may not eq to the cfg index of the other array items */

What does this mean?

> +       unsigned int cfg_idx;
> +
> +       struct virtqueue **vqs;
> +       vq_callback_t **callbacks;
> +       const char *const *names;
> +       const bool *ctx;
> +       struct irq_affinity *desc;
> +};
> +
>  struct virtio_config_ops {
>         void (*get)(struct virtio_device *vdev, unsigned offset,
>                     void *buf, unsigned len);
> @@ -103,10 +117,7 @@ struct virtio_config_ops {
>         u8 (*get_status)(struct virtio_device *vdev);
>         void (*set_status)(struct virtio_device *vdev, u8 status);
>         void (*reset)(struct virtio_device *vdev);
> -       int (*find_vqs)(struct virtio_device *, unsigned nvqs,
> -                       struct virtqueue *vqs[], vq_callback_t *callbacks[],
> -                       const char * const names[], const bool *ctx,
> -                       struct irq_affinity *desc);
> +       int (*find_vqs)(struct virtio_device *vdev, struct virtio_vq_config *cfg);
>         void (*del_vqs)(struct virtio_device *);
>         void (*synchronize_cbs)(struct virtio_device *);
>         u64 (*get_features)(struct virtio_device *vdev);
> @@ -213,8 +224,14 @@ struct virtqueue *virtio_find_single_vq(struct virtio_device *vdev,
>         vq_callback_t *callbacks[] = { c };
>         const char *names[] = { n };
>         struct virtqueue *vq;
> -       int err = vdev->config->find_vqs(vdev, 1, &vq, callbacks, names, NULL,
> -                                        NULL);
> +       struct virtio_vq_config cfg = {};
> +
> +       cfg.nvqs = 1;
> +       cfg.vqs = &vq;
> +       cfg.callbacks = callbacks;
> +       cfg.names = names;
> +
> +       int err = vdev->config->find_vqs(vdev, &cfg);
>         if (err < 0)
>                 return ERR_PTR(err);
>         return vq;
> @@ -226,7 +243,15 @@ int virtio_find_vqs(struct virtio_device *vdev, unsigned nvqs,
>                         const char * const names[],
>                         struct irq_affinity *desc)
>  {
> -       return vdev->config->find_vqs(vdev, nvqs, vqs, callbacks, names, NULL, desc);
> +       struct virtio_vq_config cfg = {};
> +
> +       cfg.nvqs = nvqs;
> +       cfg.vqs = vqs;
> +       cfg.callbacks = callbacks;
> +       cfg.names = names;
> +       cfg.desc = desc;
> +
> +       return vdev->config->find_vqs(vdev, &cfg);
>  }
>
>  static inline
> @@ -235,8 +260,16 @@ int virtio_find_vqs_ctx(struct virtio_device *vdev, unsigned nvqs,
>                         const char * const names[], const bool *ctx,
>                         struct irq_affinity *desc)
>  {
> -       return vdev->config->find_vqs(vdev, nvqs, vqs, callbacks, names, ctx,
> -                                     desc);
> +       struct virtio_vq_config cfg = {};
> +
> +       cfg.nvqs = nvqs;
> +       cfg.vqs = vqs;
> +       cfg.callbacks = callbacks;
> +       cfg.names = names;
> +       cfg.ctx = ctx;
> +       cfg.desc = desc;
> +
> +       return vdev->config->find_vqs(vdev, &cfg);
>  }
>
>  /**
> diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h
> index 9b33df741b63..0de46ed17cc0 100644
> --- a/include/linux/virtio_ring.h
> +++ b/include/linux/virtio_ring.h
> @@ -5,6 +5,7 @@
>  #include <asm/barrier.h>
>  #include <linux/irqreturn.h>
>  #include <uapi/linux/virtio_ring.h>
> +#include <linux/virtio_config.h>
>
>  /*
>   * Barriers in virtio are tricky.  Non-SMP virtio guests can't assume
> @@ -60,38 +61,25 @@ struct virtio_device;
>  struct virtqueue;
>  struct device;
>
> +struct transport_vq_config {

To reduce the confusion, let's rename this as "vq_transport_config"

Thanks






[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux