Re: [PATCH 01/14] block: move max_{open,active}_zones to struct queue_limits

[Bart Van Assche <bvanassche@xxxxxxx>]

On 1/28/24 08:58, Christoph Hellwig wrote:
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 99e4f5e722132c..4a2e82c7971c86 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -189,8 +189,6 @@ struct gendisk {
>   	 * blk_mq_unfreeze_queue().
>   	 */
>   	unsigned int		nr_zones;
> -	unsigned int		max_open_zones;
> -	unsigned int		max_active_zones;
>   	unsigned long		*conv_zones_bitmap;
>   	unsigned long		*seq_zones_wlock;
>   #endif /* CONFIG_BLK_DEV_ZONED */
> @@ -307,6 +305,8 @@ struct queue_limits {
>   	unsigned char		discard_misaligned;
>   	unsigned char		raid_partial_stripes_expensive;
>   	bool			zoned;
> +	unsigned int		max_open_zones;
> +	unsigned int		max_active_zones;

Not all struct queue_limits instances are associated with a gendisk. Do we need
a way to separate the limits that apply to all request queues from the limits
that only apply to disks in struct queue_limits, e.g. a comment that separates
the two?

Thanks,

Bart.