> > I meant that next_wrap is for packed VQs, but I see your point, it's no clear from the comment. > > I'll fix it in v2. > > next_wrap works for split as well, spec said > > " > Without VIRTIO_F_RING_PACKED this is the most significant bit (bit 15) > of the available index. > " You're right, so we can write: @kick_vq_with_data: Kick the virtqueue and supply extra data (only if VIRTIO_F_NOTIFICATION_DATA is negotiated) @vdev: vdpa device @data for split virtqueue: 16 bits vqn and 16 bits next available index. @data for packed virtqueue: 16 bits vqn, 15 least significant bits of next available index and 1 bit next_wrap. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization