On Tue, Apr 4, 2023 at 3:20 PM Alvaro Karsz <alvaro.karsz@xxxxxxxxxxxxx> wrote: > > > > + * @kick_vq_with_data: Kick the virtqueue and supply extra data > > > + * (only if VIRTIO_F_NOTIFICATION_DATA is negotiated) > > > + * @vdev: vdpa device > > > + * @data: includes vqn, next_off and next_wrap for > > > + * packed virtqueues > > > > This needs some tweaking, VIRTIO_F_NOTIFICATION_DATA works for split > > virtqueue as well. > > > > I meant that next_wrap is for packed VQs, but I see your point, it's no clear from the comment. > I'll fix it in v2. next_wrap works for split as well, spec said " Without VIRTIO_F_RING_PACKED this is the most significant bit (bit 15) of the available index. " Thanks > > Thanks > _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
