On Fri, Nov 25, 2022 at 05:08:06PM +0000, Arseniy Krasnov wrote:
From: Bobby Eshleman <bobby.eshleman@xxxxxxxxxxxxx>
This saves original behaviour from af_vsock.c - switch any error
code returned from transport layer to ENOMEM.
Signed-off-by: Bobby Eshleman <bobby.eshleman@xxxxxxxxxxxxx>
Signed-off-by: Arseniy Krasnov <AVKrasnov@xxxxxxxxxxxxxx>
---
net/vmw_vsock/vmci_transport.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
@Bryan @Vishnu what do you think about this patch?
A bit of context:
Before this series, the af_vsock core always returned ENOMEM to the user
if the transport failed to queue the packet.
Now we are changing it by returning the transport error. So I think here
we want to preserve the previous behavior for vmci, but I don't know if
that's the right thing.
@Arseniy please in the next versions describe better in the commit
messages the reasons for these changes, so it is easier review for
others and also in the future by reading the commit message we can
understand the reason for the change.
Thanks,
Stefano
diff --git a/net/vmw_vsock/vmci_transport.c b/net/vmw_vsock/vmci_transport.c
index 842c94286d31..289a36a203a2 100644
--- a/net/vmw_vsock/vmci_transport.c
+++ b/net/vmw_vsock/vmci_transport.c
@@ -1838,7 +1838,14 @@ static ssize_t vmci_transport_stream_enqueue(
struct msghdr *msg,
size_t len)
{
- return vmci_qpair_enquev(vmci_trans(vsk)->qpair, msg, len, 0);
+ int err;
+
+ err = vmci_qpair_enquev(vmci_trans(vsk)->qpair, msg, len, 0);
+
+ if (err < 0)
+ err = -ENOMEM;
+
+ return err;
}
static s64 vmci_transport_stream_has_data(struct vsock_sock *vsk)
--
2.25.1
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
