On Mon, Nov 28, 2022 at 02:26:26PM -0800, Shannon Nelson wrote: > On 11/28/22 10:29 AM, Jakub Kicinski wrote: > > On Fri, 18 Nov 2022 14:56:47 -0800 Shannon Nelson wrote: > > > + DEVLINK_PARAM_DRIVER(PDSC_DEVLINK_PARAM_ID_LM, > > > + "enable_lm", > > > + DEVLINK_PARAM_TYPE_BOOL, > > > + BIT(DEVLINK_PARAM_CMODE_RUNTIME), > > > + pdsc_dl_enable_get, > > > + pdsc_dl_enable_set, > > > + pdsc_dl_enable_validate), > > > > Terrible name, not vendor specific. > > ... but useful for starting a conversation. > > How about we add > DEVLINK_PARAM_GENERIC_ID_ENABLE_LM, I know we are running short of short acronyms and we have to recycle them, rfc5513 and all, so could you actually use DEVLINK_PARAM_GENERIC_ID_ENABLE_LIST_MANAGER making it clear your Smart NIC is running majordomo and will soon replace vger. Andrew _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization