On Fri, Nov 25, 2022 at 12:09:45AM +0200, Alvaro Karsz wrote: > > I suggest defining a separate UAPI struct for this ioctl. > > Sounds fine to me. > I could use the following struct > > struct virtio_blk_lifetime_ioctl { > u16 pre_eol_info; > u16 device_lifetime_est_typ_a; > u16 device_lifetime_est_typ_b; > u16 padding; > }; OK. What makes it virtio specific though? Don't any other block devices report lifetime? And shouldn't they share the same ioctl then? Maybe this belongs to a generic lifetime.h ? Comments documenting meaning of the fields would also be good. -- MST _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization