> hmm what does this have to do with lifetime? > Does this have something to do with lifetime? At the moment, if a request operation is REQ_OP_DRV_IN, the function virtblk_setup_cmd assigns the virtio type VIRTIO_BLK_T_GET_ID. I changed it so a REQ_OP_DRV_IN operation could have different virtio types. Instead of setting the type in virtblk_setup_cmd, the type for REQ_OP_DRV_IN operations is set in the function that creates the request (virtblk_get_id, virtblk_ioctl_lifetime) I see now that I didn't add iopprio for legacy devices, I'll add it in the next version. > You don't need the cast to void *. > Neither here. > Nor here. Ok. > block comments have wrong format I think. Are you talking about the empty top line? /* empty * line 1 * line 2 */ If so, I'll fix it. > I think if you are going to pass struct virtio_blk_lifetime to > userspace, better pass it as defined in the spec, in LE format. Ok. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
