Hi Michael, thanks for reviewing the patch. Comments below: On mié, ago 03 2022 at 02:54:28, "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote: > So I'm okay with a high level overview up to this point. > Below starts getting into details and they are not up to date > and I don't think we want to maintain a copy here. I agree I might have gone too much into code details, but I assumed those were pretty much the elementary and "fixed" parts of the subsystem, with a slow rate of changes in the fundamental stuff. If the code is prone to future changes or is outdated it's true we don't want it mentioned here but leaving this doc as a short intro to virtio won't add much to what's already available in other resources. The intention was mostly to illustrate the basic virtio concepts with the concrete implementation in the kernel. I'll see if I can find a way to do that without relying so much on specific code fragments. > the part above is duplicating too much from the spec I think. Ack. > The reference to BARs seems bogus. Got it. > why gitlab? why not https://git.qemu.org/ then? According to the QEMU website the official repo lives in gitlab. > 1.2 is out. Thanks, I didn't see it when searching for the spec. Cheers, Ricardo _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
