On Mon, May 23, 2022 at 10:00 AM Parav Pandit <parav@xxxxxxxxxx> wrote: > > > > From: Jason Wang <jasowang@xxxxxxxxxx> > > Sent: Wednesday, May 18, 2022 4:32 AM > > > > 在 2022/5/18 07:03, Parav Pandit 写道: > > >>> And regarding vduse_dev_release() and existing empty release > > >>> function, > > >> they can be dynamically allocated. > > >>> This is because they are really the struct device. > > >> I do not understand this statement, sorry. > > > It was bad sentence, my bad. > > > > > > What I wanted to say is, probably better explained with real patch below. > > > In context of [1], struct vduse_mgmtdev empty release function can be > > avoided by below inline patch [2]. > > > > > > [1]https://www.spinics.net/lists/linux-virtualization/msg56371.html > > > > > > [2] patch: > > > > > > Ok, if we go this way (looks more like mdev_parent). I think we need at least > > rename the vdpa_mgmt_device, maybe vdpa_parent (like mdev_parent)? > > > It can be. > Parent is also a device. So... How about "vdpa_parent_data"? Not a native speaker but it's better to remove "device" from the name anhow. Thanks > Since there are no further comments on the inline patch, I will send it as separate patch this week. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization