Re: [PATCH v10 63/81] KVM: introspection: add KVMI_VCPU_INJECT_EXCEPTION + KVMI_VCPU_EVENT_TRAP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi "Adalbert,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on dc924b062488a0376aae41d3e0a27dc99f852a5e]

url:    https://github.com/0day-ci/linux/commits/Adalbert-Laz-r/VM-introspection/20201125-174530
base:    dc924b062488a0376aae41d3e0a27dc99f852a5e
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/248beb976ebfd430c3535cc442d0ba198f1ab1d6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Adalbert-Laz-r/VM-introspection/20201125-174530
        git checkout 248beb976ebfd430c3535cc442d0ba198f1ab1d6
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

   arch/x86/kvm/kvmi_msg.c: In function 'handle_vcpu_inject_exception':
>> arch/x86/kvm/kvmi_msg.c:158:38: warning: variable 'arch' set but not used [-Wunused-but-set-variable]
     158 |  struct kvm_vcpu_arch_introspection *arch;
         |                                      ^~~~

vim +/arch +158 arch/x86/kvm/kvmi_msg.c

   152	
   153	static int handle_vcpu_inject_exception(const struct kvmi_vcpu_msg_job *job,
   154						const struct kvmi_msg_hdr *msg,
   155						const void *_req)
   156	{
   157		const struct kvmi_vcpu_inject_exception *req = _req;
 > 158		struct kvm_vcpu_arch_introspection *arch;
   159		struct kvm_vcpu *vcpu = job->vcpu;
   160		int ec;
   161	
   162		arch = &VCPUI(vcpu)->arch;
   163	
   164		if (!kvmi_is_event_allowed(KVMI(vcpu->kvm), KVMI_VCPU_EVENT_TRAP))
   165			ec = -KVM_EPERM;
   166		else if (req->padding1 || req->padding2)
   167			ec = -KVM_EINVAL;
   168		else if (VCPUI(vcpu)->arch.exception.pending ||
   169				VCPUI(vcpu)->arch.exception.send_event)
   170			ec = -KVM_EBUSY;
   171		else
   172			ec = kvmi_arch_cmd_vcpu_inject_exception(vcpu, req);
   173	
   174		return kvmi_msg_vcpu_reply(job, msg, ec, NULL, 0);
   175	}
   176	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux