Re: [PATCH v10 32/81] KVM: introduce VM introspection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi "Adalbert,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on dc924b062488a0376aae41d3e0a27dc99f852a5e]

url:    https://github.com/0day-ci/linux/commits/Adalbert-Laz-r/VM-introspection/20201125-174530
base:    dc924b062488a0376aae41d3e0a27dc99f852a5e
config: mips-malta_kvm_defconfig (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/6ffa5da71155bd0bed0d68c52af248bda256d0f2
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Adalbert-Laz-r/VM-introspection/20201125-174530
        git checkout 6ffa5da71155bd0bed0d68c52af248bda256d0f2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   In file included from arch/mips/kvm/../../../virt/kvm/kvm_main.c:18:
   include/linux/kvm_host.h:925:14: warning: 'struct kvm_xsave' declared inside parameter list will not be visible outside of this definition or declaration
     925 |       struct kvm_xsave *guest_xsave);
         |              ^~~~~~~~~
   include/linux/kvm_host.h:927:13: warning: 'struct kvm_xsave' declared inside parameter list will not be visible outside of this definition or declaration
     927 |      struct kvm_xsave *guest_xsave);
         |             ^~~~~~~~~
   arch/mips/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_create_vm':
>> arch/mips/kvm/../../../virt/kvm/kvm_main.c:806:6: error: 'enable_introspection' undeclared (first use in this function)
     806 |  if (enable_introspection)
         |      ^~~~~~~~~~~~~~~~~~~~
   arch/mips/kvm/../../../virt/kvm/kvm_main.c:806:6: note: each undeclared identifier is reported only once for each function it appears in
   arch/mips/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_destroy_vm':
   arch/mips/kvm/../../../virt/kvm/kvm_main.c:861:6: error: 'enable_introspection' undeclared (first use in this function)
     861 |  if (enable_introspection)
         |      ^~~~~~~~~~~~~~~~~~~~
   arch/mips/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_init':
   arch/mips/kvm/../../../virt/kvm/kvm_main.c:5012:6: error: 'enable_introspection' undeclared (first use in this function)
    5012 |  if (enable_introspection) {
         |      ^~~~~~~~~~~~~~~~~~~~

vim +/enable_introspection +806 arch/mips/kvm/../../../virt/kvm/kvm_main.c

   797	
   798		r = kvm_init_mmu_notifier(kvm);
   799		if (r)
   800			goto out_err_no_mmu_notifier;
   801	
   802		r = kvm_arch_post_init_vm(kvm);
   803		if (r)
   804			goto out_err;
   805	
 > 806		if (enable_introspection)
   807			kvmi_create_vm(kvm);
   808	
   809		mutex_lock(&kvm_lock);
   810		list_add(&kvm->vm_list, &vm_list);
   811		mutex_unlock(&kvm_lock);
   812	
   813		preempt_notifier_inc();
   814	
   815		return kvm;
   816	
   817	out_err:
   818	#if defined(CONFIG_MMU_NOTIFIER) && defined(KVM_ARCH_WANT_MMU_NOTIFIER)
   819		if (kvm->mmu_notifier.ops)
   820			mmu_notifier_unregister(&kvm->mmu_notifier, current->mm);
   821	#endif
   822	out_err_no_mmu_notifier:
   823		hardware_disable_all();
   824	out_err_no_disable:
   825		kvm_arch_destroy_vm(kvm);
   826	out_err_no_arch_destroy_vm:
   827		WARN_ON_ONCE(!refcount_dec_and_test(&kvm->users_count));
   828		for (i = 0; i < KVM_NR_BUSES; i++)
   829			kfree(kvm_get_bus(kvm, i));
   830		for (i = 0; i < KVM_ADDRESS_SPACE_NUM; i++)
   831			kvm_free_memslots(kvm, __kvm_memslots(kvm, i));
   832		cleanup_srcu_struct(&kvm->irq_srcu);
   833	out_err_no_irq_srcu:
   834		cleanup_srcu_struct(&kvm->srcu);
   835	out_err_no_srcu:
   836		kvm_arch_free_vm(kvm);
   837		mmdrop(current->mm);
   838		return ERR_PTR(r);
   839	}
   840	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux