On Wed, May 30, 2018 at 10:06:35PM -0400, Stephen Hemminger wrote: > On Thu, 24 May 2018 09:55:14 -0700 > Sridhar Samudrala <sridhar.samudrala@xxxxxxxxx> wrote: > > > Use the registration/notification framework supported by the generic > > failover infrastructure. > > > > Signed-off-by: Sridhar Samudrala <sridhar.samudrala@xxxxxxxxx> > > Why was this merged? It was never signed off by any of the netvsc maintainers, > and there were still issues unresolved. > > There are also namespaces issues I am fixing and this breaks them. > Will start my patch set with a revert for this. Sorry As long as you finish the patch set with re-integrating with failover, that's fine IMHO. I suspect it's easier to add the code to failover though - namespace things likely affect virtio as well. Lookup by ID would be an optional feature for virtio, but probably a useful one - I won't ask you to add it to virtio but it could be a mode in failover that virtio will activate down the road. And reducing the number of times we look cards up based on ID can only be a good thing. -- MST _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
