On Thu, May 31, 2018 at 08:58:12AM -0400, Stephen Hemminger wrote: > On Wed, 30 May 2018 20:03:11 -0700 > "Samudrala, Sridhar" <sridhar.samudrala@xxxxxxxxx> wrote: > > > On 5/30/2018 7:06 PM, Stephen Hemminger wrote: > > > On Thu, 24 May 2018 09:55:14 -0700 > > > Sridhar Samudrala <sridhar.samudrala@xxxxxxxxx> wrote: > > > > > >> Use the registration/notification framework supported by the generic > > >> failover infrastructure. > > >> > > >> Signed-off-by: Sridhar Samudrala <sridhar.samudrala@xxxxxxxxx> > > > Why was this merged? It was never signed off by any of the netvsc maintainers, > > > and there were still issues unresolved. > > > > > > There are also namespaces issues I am fixing and this breaks them. > > > Will start my patch set with a revert for this. Sorry > > > > I would appreciate if you can make the fixes on top of this patch series. I tried hard > > to make sure that netvsc functionality and behavior doesn't change. > > > > It is possible that there could be some bugs introduced, but they can be fixed. > > Looks like Wei already found a bug and submitted a fix for that. > > > > Ok, but several of these may clash with what you want for virtio. > Like: > - VF should be moved to namespace of virt device > - VF should be associated based on message from host with serial # not > registration notifier and MAC address. > - control operations should use master device reference rather than > searching based on MAC. > > As you can see these are structural changes. We might want to do these for virtio as well, at least as an option. -- MST _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
