Hello, On Thu, Sep 17, 2015 at 09:48:37AM -0700, James Bottomley wrote: > Well, there's an easy fix for that. We could have ida_remove() actually > free the bitmap and not cache it if it's the last layer. That way ida > would naturally empty and we wouldn't need a destructor. Tejun, would > that work? Yeah, that definitely is one way to go about it. It kinda muddles the purpose of ida_destroy() tho. I suppose we can rename it to idr_remove_all() and then do the same to idr. I'm not particularly objecting to all that but what's wrong with just calling idr_destroy() on exit paths? If missing the call in modules is an issue, maybe we can just annotate idr/ida with debugobj? Thanks. -- tejun _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization