Hello! > virtio uses vendor-specific capabilities to specify the location of > the virtio register ranges. The specification can be found here: > > http://docs.oasis-open.org/virtio/virtio/v1.0/cs01/virtio-v1.0-cs01.html#x1-690004 > > This patch adds support for decoding these capabilities to lspci. I like the patch, except for a couple of details: (1) Please follow the coding style of the rest of pciutils. (2) You assume that PCI_CAP_ID_VNDR of all Redhat devices contains virtio, but the comment nearby refers to a range of device IDs only. (3) Moving code related to vendor-defined caps to a separate file sounds good, but I think we should push the boundary a bit further: let the main switch in ls-caps.c call a function from ls-caps-vendor.c as soon as it finds PCI_CAP_ID_VENDOR, leaving all decisions based on vendor/device ID to this function. Could you please fix these and resubmit? Have a nice fortnight -- Martin `MJ' Mares <mj@xxxxxx> http://mj.ucw.cz/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth VI has two modes: the one in which it beeps and the one in which it doesn't. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
