On Mi, 2015-01-21 at 15:57 +0100, Martin Mares wrote: > Hello! > > > virtio uses vendor-specific capabilities to specify the location of > > the virtio register ranges. The specification can be found here: > > > > http://docs.oasis-open.org/virtio/virtio/v1.0/cs01/virtio-v1.0-cs01.html#x1-690004 > > > > This patch adds support for decoding these capabilities to lspci. > > I like the patch, except for a couple of details: > > (1) Please follow the coding style of the rest of pciutils. I've tried. What specifically doesn't match? > (2) You assume that PCI_CAP_ID_VNDR of all Redhat devices contains virtio, > but the comment nearby refers to a range of device IDs only. I'll add a check. Doesn't matter today, there are no other redhat devices with vendor caps, so I was a bit lazy. But who knows what happens in the future ... > (3) Moving code related to vendor-defined caps to a separate file sounds > good, but I think we should push the boundary a bit further: let the > main switch in ls-caps.c call a function from ls-caps-vendor.c as soon > as it finds PCI_CAP_ID_VENDOR, leaving all decisions based on > vendor/device ID to this function. Makes sense indeed, will do. cheers, Gerd _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
