On Wed, 26 Nov 2014 16:05:39 +0200
"Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:
> On Wed, Nov 26, 2014 at 02:54:38PM +0100, Cornelia Huck wrote:
> > On Tue, 25 Nov 2014 18:43:10 +0200
> > "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:
> > > @@ -174,6 +174,37 @@ enum {
> > >
> > > static inline int vhost_has_feature(struct vhost_virtqueue *vq, int bit)
> > > {
> > > - return vq->acked_features & (1 << bit);
> > > + return vq->acked_features & (1ULL << bit);
> >
> > Should this hunk go into patch 28?
>
> Well, this is needed here since 1 << 32 is not legal C.
>
> I can move it - this means patch 28 will have to move earlier
> in series though.
Yes, I think it makes sense to move patch 28 earlier.
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
