On Sun, Jul 6, 2014 at 10:51 PM, Amit Shah <amit.shah@xxxxxxxxxx> wrote: > On (Sun) 06 Jul 2014 [21:38:36], Kees Cook wrote: >> On Fri, Jul 4, 2014 at 10:34 PM, Amit Shah <amit.shah@xxxxxxxxxx> wrote: >> > The hwrng core asks for random data in the hwrng_register() call itself >> > from commit d9e7972619. This doesn't play well with virtio -- the >> > DRIVER_OK bit is only set by virtio core on a successful probe, and >> > we're not yet out of our probe routine when this call is made. This >> > causes the host to not acknowledge any requests we put in the virtqueue, >> > and the insmod or kernel boot process just waits for data to arrive from >> > the host, which never happens. >> >> Doesn't this mean that virtio-rng won't ever contribute entropy to the system? > > The initial randomness? Yes. But it'll start contributing entropy as > soon as it's used as the current source. How does that happen? I don't see an init function defined for it? -Kees -- Kees Cook Chrome OS Security _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization
