"Michael S. Tsirkin" <mst@xxxxxxxxxx> writes: > On Tue, Feb 12, 2013 at 11:01:10AM +0100, Sjur Brændeland wrote: >> On Tue, Feb 12, 2013 at 10:42 AM, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: >> ... >> > > > > How about setting port->guest_connected = true in the init routines >> > > > > instead? Keeps this code path cleaner. >> > > > >> > > > Agree, I'll respin this patch. >> > > >> > > Hm, Rusty has already picked this up. >> > >> > I don't see it in virtio-next. Do you? >> >> >> Yes I do, see: >> >> http://git.kernel.org/?p=linux/kernel/git/rusty/linux.git;a=commitdiff;h=1f8051876a194d7f7fe7834d9853f240d6b4b9ab;hp=226364766f936d249e408de03821468c1bf11dda >> >> Regards, >> Sjur > > Right, missed this. In this case better to send an incremental patch I > think, we don't want rebases unless absolutely required. Indeed, I try not to rebase virtio-next. pending-rebases is where I put stuff which can be wildly rebased... Cheers, Rusty. _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linuxfoundation.org/mailman/listinfo/virtualization