Re: [PATCH] virtio_console: Let unconnected rproc device receive data.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Amit,

> > @@ -1763,8 +1763,11 @@ static void in_intr(struct virtqueue *vq)
>
> > >      * tty is spawned) and the host sends out data to console
> > >      * ports.  For generic serial ports, the host won't
> > >      * (shouldn't) send data till the guest is connected.
> > > +    * However a remote device might send data before the port is
> > > +    * connected. So don't remove data from a rproc_serial device.
> > >      */
> > > -   if (!port->guest_connected)
> > > +
> > > +   if (!port->guest_connected && !is_rproc_serial(port->portdev-
> > >vdev))
> > >             discard_port_data(port);
> >
> > How about setting port->guest_connected = true in the init routines
> > instead?  Keeps this code path cleaner.
>
> Agree, I'll respin this patch.

Hm, Rusty has already picked this up. Do you still want me to do a respin,
or should I leave it as is?

Regards,
Sjur
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linuxfoundation.org/mailman/listinfo/virtualization


[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux