On Wed, Feb 23, 2011 at 04:58:10PM +0000, Hank Janssen wrote: > > Also, ff all the pr_<level>'s are using VMBUS_MOD, > > then perhaps it would look better to add > > > > #define pr_fmt(fmt) "%s: " fmt, VMBUS_MOD > > or > > #define pr_fmt(fmt) "%s:%s " fmt, VMBUS_MOD, __func__ > > (if you must) > > I wrestled with that when I did the conversion, The reason I did not > Do that is when I check other drivers very few do it that way, most do > It the way I do it or actually hard code the module name to be printed. > And since the original objection was that DPRINT seems to implement it's > own logging I did not want to re-implement the pr_XXX calls with this layer > of indirection which almost looks like I am going down the path of DPRINT > again. > > So what is the general consensus. The current way I implemented it seems > to be how other drivers use it to. The way Joe suggested is best. regards, dan carpenter _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
