On Tue, 2011-02-22 at 15:32 -0800, Hank Janssen wrote:
> This group of patches removes all DPRINT from hv_vmbus.ko.
> It is divided in several patches due to size.
[]
> - DPRINT_ERR(VMBUS_DRV,
> - "ERROR - Unable to register vmbus root device");
> + pr_err("%s: %s ERROR Unable to register vmbus root device",
> + VMBUS_MOD, __func__);
All of the pr_<level> calls should probably have a terminating "\n"
Also, ff all the pr_<level>'s are using VMBUS_MOD,
then perhaps it would look better to add
#define pr_fmt(fmt) "%s: " fmt, VMBUS_MOD
or
#define pr_fmt(fmt) "%s:%s " fmt, VMBUS_MOD, __func__
(if you must)
and then use:
pr_err("ERROR Unable to register vmbus root device\n");
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization
