On (Tue) Apr 06 2010 [12:42:58], Rusty Russell wrote: > On Mon, 5 Apr 2010 11:24:14 pm Amit Shah wrote: > > If the host port is not open, a write() should either just return if the > > file is opened in non-blocking mode, or block till the host port is > > opened. > > > > Also, don't spin till host consumes data for nonblocking ports. For > > non-blocking ports, we can do away with the spinning and reclaim the > > buffers consumed by the host on the next write call or on the condition > > that'll make poll return. > > I'm only reading the patch so I might have missed it, but what's the > locking going on here? > > Can we race thinking we're full or not full incorrectly? Yes, we can. I forgot to mention that in the changelog, I'm working on adding (and testing) the locking. Basically I wanted to send out the series in this stage for a review -- only the locking remains to be done as of now. > But the basic approach of this series seems good! Thanks! Amit _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
