Re: [PATCH 10/10] virtio: console: Add support for nonblocking write()s

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 5 Apr 2010 11:24:14 pm Amit Shah wrote:
> If the host port is not open, a write() should either just return if the
> file is opened in non-blocking mode, or block till the host port is
> opened.
> 
> Also, don't spin till host consumes data for nonblocking ports. For
> non-blocking ports, we can do away with the spinning and reclaim the
> buffers consumed by the host on the next write call or on the condition
> that'll make poll return.

I'm only reading the patch so I might have missed it, but what's the
locking going on here?

Can we race thinking we're full or not full incorrectly?

But the basic approach of this series seems good!

Thanks,
Rusty.
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization

[Index of Archives]     [KVM Development]     [Libvirt Development]     [Libvirt Users]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux