> Can we take a different approach from the zap_pte hook? Given that > we're 1) planning on claiming a pte bit for grant mappings, and 2) need > to hook ptep_get_and_clear anyway to solve the mprotect performance > problems, couldn't we just special-case grant mapping pte_clears? > > In 2.6.18-xen the only two implementations of zap_pte are > blktap_clear_pte and gntdev_clear_pte. Given a ptep with the > grant-mapping bit set, could we determine which of these need calling > and do the appropriate thing? Do we even need separate implementations > of the core pte-clearing functionality? Could we just say something like: > > if (pte & _PAGE_XEN_FOREIGN) > HYPERVISOR_grant_table_op(GNTTABOP_unmap_grant_ref, ...); > else > xen_set_pte_at(...); > Hi, In order to unmap a grant, you need the grant handle obtained when the grant is mapped. That handle needs to be stored somewhere for the lifetime of the mapping. Where would the handle be stored (as Gerd proposed) in order to be able to unmap from ptep_get_and_clear_full? I haven't looked at the paravirt ops in details so I could be missing something obvious here. cheers, geoffrey _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
