On 8/8/07, Andi Kleen <ak@xxxxxxx> wrote: > On Wednesday 08 August 2007 06:19, Glauber de Oliveira Costa wrote: > > > +static __always_inline long long vget_cycles_sync(void) > > Why is there a copy of this function now? That seems wrong Yeah, the other one is in i386 headers, so We probably wan't to leave it there. One option is to move get_cycles_sync to x86_64 headers, and then #ifdef just the offending part. > > + native_read_tscp(&p); > > The instruction is called rdtscp not read_tscp. Please follow that Although the operation consists in reading tscp. I choose this to be consistent with i386, but I have no special feelings about it. I'm okay with changing it if you prefer. > > +#define rdtsc(low, high) \ > > This macro can be probably eliminated, no callers in kernel > > Fine. -- Glauber de Oliveira Costa. "Free as in Freedom" http://glommer.net "The less confident you are, the more serious you have to act." _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization
