On Monday 23 April 2007 02:24:05 Rusty Russell wrote: > On Mon, 2007-04-23 at 01:49 +0200, Andi Kleen wrote: > > > Less exports good. Consistency with all config options isn't a hard > > > requirement: I'd be tempted not to export the pte functions. > > > > Yes paravirt_ops should be probably split into two for internal and external > > available functions. Any takers? > > Hi Andi! > > I'm a little uncomfortable with cutting the struct this way: I always > thought it'd be a function split if we did one. It's a functional split, isn't it? arch/mm internal and "exported" to other users > With the new patch code we could simply shuffle all the exportables to > the front and fail to patch calls past this point (then fail the module > load). Two structures would seem cleaner to me than such hacks. -Andi _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx https://lists.linux-foundation.org/mailman/listinfo/virtualization