Zachary Amsden wrote:
> Now that paravirt-ops is a fully patched, purely functional interface,
> which appropriately generates bugs when patches fail to get applied,
> it need no longer be exported to modules. Modules will be patched at
> load time, and need no boot time fallback which references paravirt-ops.
>
Hm, OK, I see what you're getting at.
I guess the BUG_ON()s need only fire if they're failing to patch over a
ud2a instruction.
I'm in two minds about this. On the one hand, it's a clever hack which
does achieve the desired outcome. On the other hand, it turns an
optimisation mechanism into a special-purpose ad-hoc linker which
doesn't seem like quite the right way to go. The conversion from "best
effort, doing nothing is OK" to "doing nothing is a BUG" behaviour is a
good indication of this.
J
_______________________________________________
Virtualization mailing list
Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx
https://lists.linux-foundation.org/mailman/listinfo/virtualization
