On Wed, 2007-03-07 at 14:17 -0800, Zachary Amsden wrote: > Thomas Gleixner wrote: > > Simply because you _ABUSE_ timer_init_hook() to set it up. Keep it self > > contained and do not impose restrictions on the kernel core code, which > > we have to maintain. > > > > But time_init_hook is supposed to be abused. That is its purpose - to > be a hook for different time devices on SGI Visual Workstation and > Voyager. And we don't actually abuse it anymore, we just bypass it > because the default timer init path wants to setup the PIT or the HPET, > neither of which should be used in paravirt. It is there for those hardware platforms, but using it inside your clock event device is _JUST_ wrong. Please make these things self contained and not relying on whatever time_init_hook() contains. tglx _______________________________________________ Virtualization mailing list Virtualization@xxxxxxxxxxxxxx https://lists.osdl.org/mailman/listinfo/virtualization
