On Thu, Mar 01, 2007 at 04:42:14PM -0800, Stephen Hemminger wrote: > > + > > +/** Send a packet on a net device to encourage switches to learn the > > + * MAC. We send a fake ARP request. > > + * > > + * @param dev device > > + * @return 0 on success, error code otherwise > > + */ > Why the sudden urge to use docbook format on one internal function. And it's not even proper kerneldoc but looks more like javadoc. If you want to write kerneldoc comments please also verify them by running the tools over it. > This should probably be done in generic (non driver code). > It creates lots of dependencies here. Actually the right way to do it is in userspace, as all clustering solutions do. That's whay everyone told the Xen folks by the just refuse to rip this junk out.
