On Tue, 2006-08-22 at 14:56 +0100, Alan Cox wrote: > Ar Iau, 2006-08-10 am 11:06 -0700, ysgrifennodd Jeremy Fitzhardinge: > > Rusty Russell wrote: > > > +EXPORT_SYMBOL_GPL(paravirt_ops); > > > > > This should probably be EXPORT_SYMBOL(), otherwise pretty much every > > driver module will need to be GPL... > > It would be nice not to export it at all or to protect it, paravirt_ops > is a rootkit authors dream ticket. I'm opposed to paravirt_ops until it > is properly protected, its an unpleasantly large security target if not. > > It would be a lot safer if we could have the struct paravirt_ops in > protected read-only const memory space, set it up in the core kernel > early on in boot when we play "guess todays hypervisor" and then make > sure it stays in read only (even to kernel) space. this would need a "const after boot" section; which is really not hard to make and probably useful for a lot more things.... todo++ -- if you want to mail me at work (you don't), use arjan (at) linux.intel.com
