Ar Iau, 2006-08-10 am 11:06 -0700, ysgrifennodd Jeremy Fitzhardinge: > Rusty Russell wrote: > > +EXPORT_SYMBOL_GPL(paravirt_ops); > > > This should probably be EXPORT_SYMBOL(), otherwise pretty much every > driver module will need to be GPL... It would be nice not to export it at all or to protect it, paravirt_ops is a rootkit authors dream ticket. I'm opposed to paravirt_ops until it is properly protected, its an unpleasantly large security target if not. It would be a lot safer if we could have the struct paravirt_ops in protected read-only const memory space, set it up in the core kernel early on in boot when we play "guess todays hypervisor" and then make sure it stays in read only (even to kernel) space. Once you can't patch it then the worries about rootkits and patching it that might make people want it particularly to be _GPL should mostly go away too. Alan
