On Tue, May 09, 2006 at 03:21:19PM +0200, Andi Kleen wrote: > > > +extern void stop_hz_timer(void); > > +extern void start_hz_timer(void); > > + > > +void xen_idle(void); > > + > > static char * __init machine_specific_memory_setup(void) > > { > > unsigned long max_pfn = xen_start_info->nr_pages; > > @@ -65,4 +70,23 @@ static void __init machine_specific_arch > > console_use_vt = 0; > > conswitchp = NULL; > > } > > + > > + pm_idle = xen_idle; > > +} > > + > > +void xen_idle(void) > > I think that should be in some .c file, not a .h > > Probably applies to more of your functions too. I guess I agree, although I was mostly following the examples in other mach setup_arch_*.h files. christian