Re: XHCI: Ring expansion failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 18 Dec 2013, Sarah Sharp wrote:

> I think there's a couple of ways we could fix this.
> 
> One would be to set the IOC flag on the last no-op TRBs in a TD we're
> trying to cancel.  I think that will make the event handling code
> increment the dequeue pointer and update the number of free TRBs on the
> ring (or the code could be changed to do so).  That would take care of
> the num_trbs_free counting issue for URB cancellation that isn't part of
> device suspend.

Why not just keep the existing IOC flag setting when you convert a TRB 
into a no-op?  Then the number of events generated by the hardware will 
be the same as it would have been.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux