Re: xHCI quirk increases module load time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 3 Dec 2013, Sarah Sharp wrote:

> Hi Oliver and Takashi,
> 
> In 3.12-rc5, I merged this patch from you:
> 
> commit 638298dc66ea36623dbc2757a24fc2c4ab41b016
> Author: Takashi Iwai <tiwai@xxxxxxx>
> Date:   Thu Sep 12 08:11:06 2013 +0200

...
>     This patch introduces a new quirk, XHCI_SPURIOUS_WAKEUP, for
>     fixing the spurious wakeups at S5 by calling xhci_reset() in the xhci
>     shutdown ops as done in xhci_stop(), and setting the device to PCI D3
>     at shutdown and remove ops.
...

> When testing with Intel BIOSes on Lynx Point LP systems, we found that
> it increases the xHCI module load time by about 100ms (load time is
> normally around 30ms).  Load time is increased both when the module is
> loaded at boot, and when the module is unloaded and reloaded with
> modprobe.  Measurements were taken by adding initcall_debug to the
> kernel boot parameters, and looking at how long it took xhci_hcd_init to
> return.
> 
> I'd like to avoid a 3x increase in xHCI module load time at boot.  Would
> it be possible to narrow the quirk down to systems with the particular
> BIOS installed that needs the host to be in D3 before S5?

If all the commit does is change the behavior when the module is
unloaded, why should it make any difference to the load time?  That
doesn't make any sense.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux