> > usb: chipidea: hw_phymode_configure moved before ci_usb_phy_init usb: chipidea: put hw_phymode_configure before ci_usb_phy_init Besides, a blank line is needed between your subject and commit log. > hw_phymode_configure configures the PORTSC registers and allow the > following phy_inits to operate on the right parameters. This fix a > problem > where the UPLI (ISP1504) could not detected, ^^be > because the Viewport was not > available and read the viewport return 0's only. > > Signed-off-by: Chris Ruehl <chris.ruehl@xxxxxxxxxxxx> > Acked-by: Peter Chen <peter.chen@xxxxxxxxxxxxx> > --- > drivers/usb/chipidea/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > index 2834801..43897dd 100644 > --- a/drivers/usb/chipidea/core.c > +++ b/drivers/usb/chipidea/core.c > @@ -564,6 +564,8 @@ static int ci_hdrc_probe(struct platform_device *pdev) > return -ENODEV; > } > > + hw_phymode_configure(ci); > + > ret = ci_usb_phy_init(ci); > if (ret) { > dev_err(dev, "unable to init phy: %d\n", ret); > @@ -581,8 +583,6 @@ static int ci_hdrc_probe(struct platform_device *pdev) > > ci_get_otg_capable(ci); > > - hw_phymode_configure(ci); > - > dr_mode = ci->platdata->dr_mode; > /* initialize role(s) before the interrupt is requested */ > if (dr_mode == USB_DR_MODE_OTG || dr_mode == USB_DR_MODE_HOST) { > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html