Best regards, Peter Chen > -----Original Message----- > From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb- > owner@xxxxxxxxxxxxxxx] On Behalf Of Chris Ruehl > Sent: Friday, November 29, 2013 3:20 PM > To: alexander.shishkin@xxxxxxxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx > Cc: linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Chris Ruehl > Subject: [PATCH 2/3 v2] usb: chipidea: Fix Internal error: : 808 [#1] ARM > related to STS flag > > usb: chipidea: Fix Internal error: : 808 [#1] ARM related to STS flag > > * init the sts flag to 0 (missed) > * set the sts flag only if not 0 > > Signed-off-by: Chris Ruehl <chris.ruehl@xxxxxxxxxxxx> > --- > drivers/usb/chipidea/core.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c > index 5075407..1a6010e 100644 > --- a/drivers/usb/chipidea/core.c > +++ b/drivers/usb/chipidea/core.c > @@ -245,6 +245,8 @@ static void hw_phymode_configure(struct ci_hdrc *ci) > { > u32 portsc, lpm, sts = 0; > > switch (ci->platdata->phy_mode) { > case USBPHY_INTERFACE_MODE_UTMI: > portsc = PORTSC_PTS(PTS_UTMI); > @@ -273,10 +275,12 @@ static void hw_phymode_configure(struct ci_hdrc *ci) > > if (ci->hw_bank.lpm) { > hw_write(ci, OP_DEVLC, DEVLC_PTS(7) | DEVLC_PTW, lpm); > - hw_write(ci, OP_DEVLC, DEVLC_STS, sts); > + if (sts) > + hw_write(ci, OP_DEVLC, DEVLC_STS, sts); > } else { > hw_write(ci, OP_PORTSC, PORTSC_PTS(7) | PORTSC_PTW, portsc); > - hw_write(ci, OP_PORTSC, PORTSC_STS, sts); > + if ( sts ) > + hw_write(ci, OP_PORTSC, PORTSC_STS, sts); > } > } > > -- Acked-by: Peter Chen <peter.chen@xxxxxxxxxxxxx> Peter -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
