Hello,
On 2013-11-27 18:47, Felipe Balbi wrote:
On Wed, Nov 27, 2013 at 02:03:22PM +0100, Marek Szyprowski wrote:
> On device tree based Samsung SoC platforms (like Exynos) no platform
> devices are defined and CONFIG_S3C_DEV_USB_HSOTG is no longer available,
> so change the driver dependency to more generic and appropriate
> CONFIG_PLAT_SAMSUNG, as the driver can be used on almost all Samsung
> platforms.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---
> drivers/usb/gadget/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index a91e642..83983ee 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -295,7 +295,7 @@ config USB_PXA27X
>
> config USB_S3C_HSOTG
> tristate "S3C HS/OtG USB Device controller"
> - depends on S3C_DEV_USB_HSOTG
> + depends on PLAT_SAMSUNG
I would rather change this to depends on ARM || COMPILE_TEST, this would
force people to make sure that driver can be used on single zImage
kernels.
FranklyI don't like to see dozens of drivers available for configurations,
which cannot make any use those drivers, but if you like such approach, I
won't mind. Do you want my ack for your proposal?
All you need is the diff below:
diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
index 9875d9c..db797f2 100644
--- a/drivers/usb/gadget/s3c-hsotg.c
+++ b/drivers/usb/gadget/s3c-hsotg.c
@@ -36,8 +36,6 @@
#include <linux/usb/phy.h>
#include <linux/platform_data/s3c-hsotg.h>
-#include <mach/map.h>
-
#include "s3c-hsotg.h"
static const char * const s3c_hsotg_supply_names[] = {
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
