RE: [PATCH 01/68] xhci: fix usb3 streams

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> From: Hans de Goede
> Sent: 15 November 2013 15:06
> To: Sarah Sharp
> Cc: linux-usb@xxxxxxxxxxxxxxx; Gerd Hoffmann; Alan Stern; Hans de Goede
> Subject: [PATCH 01/68] xhci: fix usb3 streams
> 
> From: Gerd Hoffmann <kraxel@xxxxxxxxxx>
> 
> xhci maintains a radix tree for each stream endpoint because it must
> be able to map a trb address to the stream ring.  Each ring segment
> must be added to the ring for this to work.  Currently xhci sticks
> only the first segment of each stream ring into the radix tree.
> ...

Seems to me that this code fails badly on the KISS principle.

If an 'event data' TRB were added to all transfers, then in the
normal case the 64bit value in it could be used to identify
which transfer completed.
In the unusual case of an error event just search through
the endpoints/rings (etc) until the correct one is found.

	David



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux