On Thu, Nov 14, 2013 at 7:56 AM, Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote: > On Thu, Nov 14, 2013 at 12:09:46AM -0200, Fabio Estevam wrote: >> @@ -107,10 +108,22 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev) >> return ret; >> } >> >> + data->clk_phy = devm_clk_get(&pdev->dev, "phy"); >> + if (IS_ERR(data->clk_phy)) { >> + data->clk_phy = NULL; >> + } else { > > Please stop using NULL as a indicator with functions which only return > failure as an error pointer. Replace the above three lines with Thanks, fixed it in v2. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html