Dan Williams <dcbw@xxxxxxxxxx> writes: >> > So the net-port parts of qmi_wwan just do "standard" ECM then? >> >> Yes. Only the descriptors are weird. The rest is standard ECM. > > Well, including all the IPv4/IPv6 quirks? No, all the firmware bugs are very implementation specific :-) I don't know if the ECM similarity is intentional or not. It's really a simple protocol, just transmitting plain ethernet frames over bulk USB. > Those seem to be Qualcomm > specific; especially where the rawip/8023 and QoS options are concerned. > Were we ever to support rawip or the QoS options, we'd need a completely > different driver. Yes. > My suggestion here would be to create a new "cdc-ecm" driver (like we > did for cdc_eem or cdc_ether or cdc_ncm) and make qmi_wwan a sub-driver > of that (if that's even needed given these all are subdrivers of > usbnet). This way we keep "standard" ECM in one place and pile all the > vendor-specific hacks into sub-drivers instead of tangling them all > together? This is pretty much what we already have there... All the networking code is in usbnet, and already shared with cdc_ether. The code in qmi_wwan is just a) device specific probing b) enabling the cdc-wdm subdriver c) quirks Nothing more. Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
