Re: [RFCv2 2/4] usb: gadget: ep: add feature flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/08/2013 07:39 PM, Felipe Balbi wrote:
> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> index 942ef5e..cf1d027 100644
> --- a/include/linux/usb/gadget.h
> +++ b/include/linux/usb/gadget.h
> @@ -177,6 +183,13 @@ struct usb_ep {
>  	u8			address;
>  	const struct usb_endpoint_descriptor	*desc;
>  	const struct usb_ss_ep_comp_descriptor	*comp_desc;
> +
> +	unsigned		has_bulk:1;
> +	unsigned		has_control:1;
> +	unsigned		has_interrupt:1;
> +	unsigned		has_isochronous:1;
> +	unsigned		has_dir_in:1;
> +	unsigned		has_dir_out:1;
>  };

I am not a big fan this bitfields but this is another story.
One thing you might want to add later (because we do one thing at a
time) is that you might want to prefer one kind of an endpoint. For
instance you want hold back "this-ep" and not give it away for INTR
because it can do double buffer and DMA and you would like to give it
away for 512bytes BULK type of endpoints.
Another restriction is that an endpoint can do INTR, BULK, ISO but has
only a 64byte sized fifo and you would like to give it away as soon as
possible.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux