Re: conversion to dynamic debug and CONFIG_USB_DEBUG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 08, 2013 at 02:57:05PM +0100, Oliver Neukum wrote:
> On Thu, 2013-11-07 at 07:56 -0800, Greg KH wrote:
> 
> > EHCI looks like it can be easily fixed, OHCI will take some more work,
> > as will UHCI.  The other "minor" hcd drivers should be easy to resolve
> > as well, like I did previously with some of the other ones.  I'll gladly
> > take patches for all of that if you want to do it, as I really do want
> > to get rid of CONFIG_USB_DEBUG soon.
> 
> Not all of it can be solved with dynamic debugging. Debugfs
> is also used. Do you really want to keep specific config
> options for all those host drivers? It seems neater to have
> one switch for all stuff that can't be done dynamically.

I don't want anyone to ever have to rebuild their kernel to get
debugging options, as users can't do that.

debugfs files are fine to always create, the only issue is if it takes
extra overhead keeping those statistics that the debugfs files show if
nothing is ever looking at them.  That's one reason I didn't do the OHCI
driver conversion yet, I didn't have a feeling if there was going to be
extra overhead.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux