On 11/07/2013 02:37 PM, George Cherian wrote:
> Call try_to_freeze() in sleep_thread() only when its safe to sleep.
> do_read() and do_write() calls sleep_thread with lock held.
> Make sure these wont call try_to_freeze() by passing can_freeze flag
> to sleep_thread.
Thank you. This is was Alan asked for and I forgot.
You could add
|Calling try_to_freeze() with a lock hold was done since day one in
|f_mass_storage but since commit 0f9548ca1 ("lockdep: check that no
|locks held at freeze time") lockdep complains about it.
so we have an explanation why it is suddenly a bad thing.
> Signed-off-by: George Cherian <george.cherian@xxxxxx>
Acked-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
