Re: Need testers for long-standing xHCI clear halt bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

We also did the testing and it's working for us too with only patch1 applied.

Regards
Bálint

2013/10/15 Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>:
> On Sat, Oct 12, 2013 at 09:25:17AM +0200, Marcus Meissner wrote:
>> Hi Sarah,
>>
>> I built:
>>
>> - current kernel git with SUSE config
>> - libgphoto2 with the clear_halt reenabled
>> - rebooted
>>
>> gphoto2 now hangs on the second try
>>
>> - only applied both patches referenced.
>>   I need to whack them a bit as xhci_giveback_urb_in_irq got a new parameter
>> - rebuilt, rebooted
>>
>> gphoto2 now works on multiple tries.
>>
>> So the patches seem to fix the issue for my usecase.
>
> Great!  Can you also try it without the second patch?  It's not needed,
> but I want to double check that the code still works without it.
>
> Thanks,
> Sarah Sharp
>
>> On Thu, Oct 10, 2013 at 02:43:49PM -0700, Sarah Sharp wrote:
>> > Hi Sipter and Marcus,
>> >
>> > Xenia has a potential fix for a long-standing bug in the xHCI driver,
>> > and I need your help testing it.  You ran into that bug back in Feb
>> > 2013:
>> >
>> > http://sourceforge.net/mailarchive/forum.php?thread_name=CAGjSPUAQ8phZFu9dj60wt9zZpoghcQMVUAwgd2y3NvLmiAZH7Q%40mail.gmail.com&forum_name=libusbx-devel
>> >
>> > The issue was that gphoto2 unconditionally cleared a halt on all
>> > endpoints after the camera was closed.  This triggered a bug in the xHCI
>> > driver, making it so gphoto2 couldn't talk to the device on a subsequent
>> > open.  You worked around the issue by removing the clear halt in
>> > gphoto2.
>> >
>> > Now Xenia has a potential fix for that bug, and she needs help testing
>> > that fix.  Would it be possible to add that clear halt back into
>> > gphoto2, apply the following two kernel patches, and make sure gphoto2
>> > still works?
>> >
>> > http://marc.info/?l=linux-usb&m=138116117104619&w=2
>> > http://marc.info/?l=linux-usb&m=138116117204620&w=2
>> >
>> >
>> > Hi Pratyush,
>> >
>> > I believe you also ran into this issue back in Sept 2012, when you were
>> > running usbtest #13 (Endpoint Halt Test) under a TI xHCI host.  The
>> > tests failed for devices under xHCI.  If you can still reproduce that
>> > issue, can you try the test again with the two patches?
>> >
>> >
>> > Hi Yuliya,
>> >
>> > You ran into this issue as well, back in Oct 2012.  You added a set
>> > interface to your driver to work around the issue.  If you're still
>> > working on that code, can you take the set interface out, test these two
>> > patches, and let me know if your device works?
>> >
>> > Thanks,
>> > Sarah Sharp
>> >
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux