Re: [PATCH 1/5] usb: gadget: s3c-hsotg: Include linux/of.h header

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sat, Oct 19, 2013 at 02:17:52PM -0700, Greg KH wrote:
> On Thu, Oct 17, 2013 at 01:55:02PM +0530, Sachin Kamat wrote:
> > 'of_match_ptr' is defined in linux/of.h. Include it explicitly to
> > avoid build breakage in the future.
> 
> Why, what is going to happen in the "future"?
> 
> Kernel development is almost always about the "now", who knows what is
> going to happen later.  If you want to make a change that will require
> this type of file to be included, then do it, and fix things up.
> 
> Otherwise I'm not going to take this series for things that are not a
> real problem/issue, sorry.

What happened to the whole "no indirect includes" mentality ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux